----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7338/#review12031 -----------------------------------------------------------
I've patched this in and I'm seeing a a failing test: [ RUN ] CgroupsTest.ROOT_CGROUPS_ListenEvent ../../src/tests/cgroups_tests.cpp:365: Failure Value of: cgroups::writeControl(hierarchy, "/prof", "memory.oom_control", "1").isSome() Actual: false Expected: true [ FAILED ] CgroupsTest.ROOT_CGROUPS_ListenEvent (290 ms) - Ben Mahler On Sept. 28, 2012, 5:33 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7338/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2012, 5:33 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > The recent refactor changes break the assumptions in the cgroups code. > > > Diffs > ----- > > src/linux/cgroups.cpp cdafe6e > third_party/libprocess/include/stout/os.hpp 13dbc71 > > Diff: https://reviews.apache.org/r/7338/diff/ > > > Testing > ------- > > make check. > > Tested on my vm (latest ubuntu 12.04) > > > Thanks, > > Jie Yu > >
