> On Sept. 28, 2012, 7:20 p.m., Vinod Kone wrote: > > third_party/libprocess/include/process/http.hpp, line 239 > > <https://reviews.apache.org/r/7272/diff/1/?file=160108#file160108line239> > > > > Rephrase? > > > > Returns error on the occurence of a malformed % in s.
done. > On Sept. 28, 2012, 7:20 p.m., Vinod Kone wrote: > > third_party/libprocess/include/process/http.hpp, line 186 > > <https://reviews.apache.org/r/7272/diff/1/?file=160108#file160108line186> > > > > s/encodeURIComponent/encodeURI ? Just FYI I borrowed the names of these functions from the javascript builtins: encodeURIComponent / decodeURIComponent. Changed to encodeURI / decodeURI (however, note that the input string does not have to be a URI, but can be a component of a URI). > On Sept. 28, 2012, 7:20 p.m., Vinod Kone wrote: > > third_party/libprocess/include/process/http.hpp, line 252 > > <https://reviews.apache.org/r/7272/diff/1/?file=160108#file160108line252> > > > > probably useful to also include the position 'i' in the error string. Done, but instead I decided to return the malformed bit of the string. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7272/#review12030 ----------------------------------------------------------- On Sept. 25, 2012, 11:01 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7272/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2012, 11:01 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > We currently don't decode percent-encoded queries! > > > Diffs > ----- > > src/tests/files_tests.cpp 17d284b82de4d9e1dedf1c26f4cedcf8269c4072 > third_party/libprocess/include/process/http.hpp > d680261f9a460627e0ea8c492b38c6dac83f3b56 > third_party/libprocess/src/decoder.hpp > f582faf985a17b1b333331da3582caa20b806ec0 > third_party/libprocess/src/tests.cpp > 1df7ae61f24643a0ceab146646e77da6909dfd5f > > Diff: https://reviews.apache.org/r/7272/diff/ > > > Testing > ------- > > Tests for encoding / decoding. > > > Thanks, > > Ben Mahler > >
