> On Oct. 10, 2012, 7:42 p.m., Vinod Kone wrote: > > src/files/files.cpp, line 289 > > <https://reviews.apache.org/r/7123/diff/4/?file=175145#file175145line289> > > > > Suggestion: Make BadRequest() smart enough to include "\n" if not > > present at the end. > > > > It is kinda confusing, for users to know when to use it?
Done! I made a parent ErrorResponse that does this logic. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7123/#review12317 ----------------------------------------------------------- On Oct. 9, 2012, 11:16 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7123/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2012, 11:16 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > Uses the HTTP PATH type response instead. > > > This addresses bug MESOS-275. > https://issues.apache.org/jira/browse/MESOS-275 > > > Diffs > ----- > > src/files/files.cpp c40b7b74485dc717c4291f17a4533b52f2c51a7e > src/tests/files_tests.cpp 17d284b82de4d9e1dedf1c26f4cedcf8269c4072 > src/tests/utils.hpp 63f8d881da9b06f941bb104546ae03c47d140de0 > third_party/libprocess/include/stout/os.hpp > 13dbc715ed08cfe6b24ee20744d427dac1104694 > third_party/libprocess/src/process.cpp > fde7154f9a4432acaff09849c0fa69c0694c9834 > > Diff: https://reviews.apache.org/r/7123/diff/ > > > Testing > ------- > > added download test > > > Thanks, > > Ben Mahler > >
