Re: Review Request: Updated process::http::Response (and subclasses) to require more explicit distinction between an empty body and no body. Also put in place the foundation for streaming via pipes.

[Ben Mahler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7542/#review12364
-----------------------------------------------------------



third_party/libprocess/include/process/http.hpp
<https://reviews.apache.org/r/7542/#comment26163>

    Giant paragraph comment, I think breaking this comment down per-type would 
be clearer.
    
    Maybe be a bit clearer on what the pipe provider needs to handle? Does 
he/she need to specifically handle SIGPIPE?



third_party/libprocess/src/encoder.hpp
<https://reviews.apache.org/r/7542/#comment26164>

    'headers' is now a hashmap, which has contains().



third_party/libprocess/src/encoder.hpp
<https://reviews.apache.org/r/7542/#comment26165>

    ditto


- Ben Mahler


On Oct. 11, 2012, 7:48 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7542/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2012, 7:48 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/include/process/http.hpp 
> 3d2922507bdb904e5bdebefbafb6ccae98c021c4 
>   third_party/libprocess/src/encoder.hpp 
> 00e86610257b4956ceed13cd3e27e948ea53308e 
> 
> Diff: https://reviews.apache.org/r/7542/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>