----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7552/#review12430 -----------------------------------------------------------
src/webui/master/static/app.js <https://reviews.apache.org/r/7552/#comment26366> Seconds? Really? ;) src/webui/master/static/app.js <https://reviews.apache.org/r/7552/#comment26367> /dom/DOM/ src/webui/master/static/controllers.js <https://reviews.apache.org/r/7552/#comment26368> Just to verify, this works for the string '/foo/'? src/webui/master/static/controllers.js <https://reviews.apache.org/r/7552/#comment26369> Maybe a comment reminding why some route params can be absent? src/webui/master/static/controllers.js <https://reviews.apache.org/r/7552/#comment26370> I think a comment about how, and when, and if, 'host' gets set (since it's set to the empty string above) is necessary. In fact, if there is a way to restructure such that host is always set, that sounds even better. For example, maybe we define $scope.log inside the update function (below) after we precisely know host? Also, didn't this become '/slave/log'!? src/webui/master/static/controllers.js <https://reviews.apache.org/r/7552/#comment26371> s/executor_map/executors/ src/webui/master/static/controllers.js <https://reviews.apache.org/r/7552/#comment26373> I wasn't expecting you to need to do this for this missing alert. See my comment below about the missing alerts. src/webui/master/static/slave_framework.html <https://reviews.apache.org/r/7552/#comment26372> Okay, some form of a missing alert is in almost every file (and some are slightly different). Seems like we need to unify and share please. - Benjamin Hindman On Oct. 11, 2012, 7:35 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7552/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2012, 7:35 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > The new webui now has pages for slaves, including frameworks and executors > running within them. > > This also adds file browsing of active executor sandboxes. > > > This addresses bug MESOS-263. > https://issues.apache.org/jira/browse/MESOS-263 > > > Diffs > ----- > > src/master/http.cpp 8f59edfa91560a04a1bfbc891cfb585ac0074a28 > src/slave/http.cpp 9e706eaf10f3e295957c855f27aaca0709fc76d6 > src/webui/master/static/app.js de793f81da9d12c0eafa33c795f7f2b716e2c931 > src/webui/master/static/browse.html PRE-CREATION > src/webui/master/static/controllers.js > 81cd1a861dcf86fb8852999a017595824dffb3f0 > src/webui/master/static/framework.html > ed09ab883ed11126e10a465b0e4755a23c624155 > src/webui/master/static/frameworks.html > 8a52bfd186f13e35069f40420c968431ea6cb70b > src/webui/master/static/home.html 77eea93c7080de93766572a3a2d5464bbab40587 > src/webui/master/static/slave.html 58a36bb4ead9802764f43eab04a230c6f7080481 > src/webui/master/static/slave_executor.html PRE-CREATION > src/webui/master/static/slave_framework.html PRE-CREATION > src/webui/master/static/slaves.html > 6ec9d2162cda4fe8c456ae4ad0ba57d087cb4851 > > Diff: https://reviews.apache.org/r/7552/diff/ > > > Testing > ------- > > make check > mesos-local.sh + long-lived-framework > > > Screenshots > ----------- > > Slave > https://reviews.apache.org/r/7552/s/3/ > Slave Framework > https://reviews.apache.org/r/7552/s/4/ > Slave Executor > https://reviews.apache.org/r/7552/s/5/ > Browsing > https://reviews.apache.org/r/7552/s/6/ > > > Thanks, > > Ben Mahler > >
