> On Oct. 17, 2012, 6:43 p.m., Vinod Kone wrote: > > src/tests/utils.hpp, line 860 > > <https://reviews.apache.org/r/7619/diff/1/?file=177247#file177247line860> > > > > s/future/actual/? i think its more intuitive, but i will leave it upto > > you.
I did this everywhere, and also chaned 'lexpr' and 'rexpr' to 'expectedExpr' and 'actualExpr' respectively. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7619/#review12520 ----------------------------------------------------------- On Oct. 24, 2012, 4:39 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7619/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2012, 4:39 a.m.) > > > Review request for mesos, Vinod Kone and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/allocator_tests.cpp ed52ff61b1820cb3f5f7f2ae421fb3f84a85939a > src/tests/configurator_tests.cpp d24fc263dffcddac34155e5b6374227e77741ddf > src/tests/files_tests.cpp 4ae1933bda4cf4c96196843848072f0f7d2b2b65 > src/tests/flags_tests.cpp 82d7899fb942d9e770f487c1dbbe8ad16f6fbd1e > src/tests/fs_tests.cpp c1d86fe091b5d41c4a1b993d43ec3217b30e0621 > src/tests/log_tests.cpp 26aa9dda5e95f3235fff83970978fe79247ada3e > src/tests/master_detector_tests.cpp > fb32af8130d3f359eecba5389c2e42c247d6b70e > src/tests/master_tests.cpp 37e97e0a58a0128579f155183b7e769ab4e1b452 > src/tests/proc_tests.cpp 020c9ba4febc004fef3fe7f10c82203fa1efed47 > src/tests/protobuf_io_tests.cpp 5cc167dbe28f6f348e54d6885bef0b42b9512be9 > src/tests/slave_state_tests.cpp 0e232ff3ed773f3bdccc05e716b66d106d80fb2f > src/tests/state_tests.cpp 0b4aac28f087ad4032fb37f536fb90cd0649e500 > src/tests/stout_tests.cpp dcf605c7231eb6b5fdbfbbb9986a44546ba451a8 > src/tests/utils.hpp 4066c02b23db15310104955465c4e4afd7bcad5b > src/tests/values_tests.cpp 4de76c534ed18bc3dca5ebffd45cedeb025faff2 > src/tests/zookeeper_tests.cpp 4415a33b94dd6ca360a7dd3ca49f4c29ee25f5e8 > > Diff: https://reviews.apache.org/r/7619/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
