----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7723/#review12769 -----------------------------------------------------------
Ship it! src/tests/script.cpp <https://reviews.apache.org/r/7723/#comment27318> I still feel like this convention is unmaintainable, but maybe at least whitespace align the comments? src/tests/script.cpp <https://reviews.apache.org/r/7723/#comment27321> Maybe a warning to not use glog at this point, to prevent other cases cropping up? Up to you. - Ben Mahler On Oct. 24, 2012, 6:35 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7723/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2012, 6:35 a.m.) > > > Review request for mesos, Vinod Kone and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am cf9364ea0418ec30a75b1774f32bda8de6e031ac > src/tests/balloon_framework_test.sh PRE-CREATION > src/tests/cgroups_isolation_tests.cpp > 16b029675ba11030d313b93afa30c84cfef5e14d > src/tests/examples_tests.cpp PRE-CREATION > src/tests/external.hpp PRE-CREATION > src/tests/external.cpp PRE-CREATION > src/tests/external/CgroupsIsolation/ROOT_CGROUPS_BalloonFramework.sh > 7cbd0749011970184158e3bb6c28820d47613327 > src/tests/external/ExamplesTest/CppFramework.sh PRE-CREATION > src/tests/external/ExamplesTest/JavaExceptionFramework.sh PRE-CREATION > src/tests/external/ExamplesTest/JavaFramework.sh PRE-CREATION > src/tests/external/ExamplesTest/NoExecutorFramework.sh PRE-CREATION > src/tests/external/ExamplesTest/PythonFramework.sh PRE-CREATION > src/tests/external/KillTree/KillTreeTest.sh > 396295470887ef8b36f1c5eb820a43ef95b5459e > src/tests/external/LxcIsolation/HoldMoreMemThanRequested.sh > a2bd9c499479bb7198ddb6b1a329bf16ff233109 > src/tests/external/LxcIsolation/ScaleUpAndDown.sh > 2c43ec7dc950113b4d1214e0f331550b6f35059d > src/tests/external/LxcIsolation/TwoSeparateTasks.sh > 10fc3749498446763d1c7f9caa503c902987edfb > src/tests/external/LxcIsolation/run_scheduled_memhog_test.sh > a3a6c50a36426156022f8b8d052d443e8371ce59 > src/tests/java_exception_test.sh PRE-CREATION > src/tests/java_framework_test.sh PRE-CREATION > src/tests/killtree_test.sh PRE-CREATION > src/tests/killtree_tests.cpp 32478fe5089b79157df4d2505ccc232bb7170010 > src/tests/no_executor_framework_test.sh PRE-CREATION > src/tests/python_framework_test.sh PRE-CREATION > src/tests/script.hpp PRE-CREATION > src/tests/script.cpp PRE-CREATION > src/tests/test_framework_test.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/7723/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
