> On Oct. 24, 2012, 9:12 p.m., Ben Mahler wrote: > > third_party/libprocess/include/stout/os.hpp, line 192 > > <https://reviews.apache.org/r/7717/diff/1/?file=179349#file179349line192> > > > > From what I read: "The last six characters of template must be XXXXXX" > > > > So perhaps we don't want users passing in the X's.
This is just a wrapper around the syscall, so I'd rather let it be as leaky an abstraction as possible for now. We can revisit this later. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7717/#review12725 ----------------------------------------------------------- On Oct. 24, 2012, 4:52 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7717/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2012, 4:52 a.m.) > > > Review request for mesos, Vinod Kone and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > third_party/libprocess/include/stout/os.hpp > 19429186ee7f016c999809d194825e98d9e084df > > Diff: https://reviews.apache.org/r/7717/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
