> On Oct. 29, 2012, 5:59 p.m., Vinod Kone wrote: > > src/linux/cgroups.cpp, lines 1519-1534 > > <https://reviews.apache.org/r/7756/diff/1/?file=181105#file181105line1519> > > > > I understand this code is a copy paste from initialize(), but I don't > > follow the flow here. > > > > Can someone explain?
Discussed offline. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7756/#review12872 ----------------------------------------------------------- On Oct. 29, 2012, 5:45 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7756/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2012, 5:45 a.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Description > ------- > > Parent Review: https://reviews.apache.org/r/7712/ > > We'd like to retry the freeze, kill, thaw, watchEmpty steps when the freezing > of the cgroups fails. > > This simply retries the above steps when the cgroup does not become empty in > the given time interval. > > > Diffs > ----- > > src/linux/cgroups.hpp 8147919 > src/linux/cgroups.cpp a6056c3 > > Diff: https://reviews.apache.org/r/7756/diff/ > > > Testing > ------- > > make check on ubuntu > > This version punts on testing for now, but testing suggestions welcome! > > > Thanks, > > Ben Mahler > >
