-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7855/#review13112
-----------------------------------------------------------



src/Makefile.am
<https://reviews.apache.org/r/7855/#comment28246>

    Wasn't this reformatting in a different review?



src/Makefile.am
<https://reviews.apache.org/r/7855/#comment28247>

    Does underscore have a version too? It would be great to include the 
version number if applicable.



src/Makefile.am
<https://reviews.apache.org/r/7855/#comment28248>

    Is this jquery-1.7.1? I want to make sure people that are debugging stuff 
will be looking at the correct version (since they won't debug by looking at 
the min code). If it is, please rename this file to include the version number. 
If not, please replace this file with the jquery-1.7.1 version (named 
appropriately).


- Benjamin Hindman


On Nov. 3, 2012, 10:19 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7855/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2012, 10:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> Saves around 750KB of content to send over the wire, for little effort.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f 
>   src/webui/master/static/angular-1.0.0rc8.min.js PRE-CREATION 
>   src/webui/master/static/bootstrap/js/jquery-1.7.1.min.js PRE-CREATION 
>   src/webui/master/static/cubism.v1.min.js PRE-CREATION 
>   src/webui/master/static/d3.v2.min.js PRE-CREATION 
>   src/webui/master/static/index.html 5e03ef6d054fab962657c1598888e65232f4c7e3 
> 
> Diff: https://reviews.apache.org/r/7855/diff/
> 
> 
> Testing
> -------
> 
> Local runs, made sure to not forget adding to the Makefile this time.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to