----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7854/#review13113 -----------------------------------------------------------
Ship it! src/webui/master/static/jquery.pailer.js <https://reviews.apache.org/r/7854/#comment28252> Me learning: is this actually necessary? Won't the "stringification" below via concatenation just "do the right thing"? src/webui/master/static/jquery.pailer.js <https://reviews.apache.org/r/7854/#comment28251> Are you missing '`': '`'? src/webui/master/static/jquery.pailer.js <https://reviews.apache.org/r/7854/#comment28250> s/escapeRegex/regex/ (given your naming above, 'escapeHTML', I'm thinking escapeRegex means a function for escaping a regular expression). src/webui/master/static/jquery.pailer.js <https://reviews.apache.org/r/7854/#comment28249> Me learning: is there not the analog of 'stringify' in JS that does this concatenation? - Benjamin Hindman On Nov. 3, 2012, 9:06 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7854/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2012, 9:06 p.m.) > > > Review request for mesos, Benjamin Hindman and Brian Wickman. > > > Description > ------- > > Added our own helper because it appears jquery doesn't support it: > http://bugs.jquery.com/ticket/11773 > > Ideally, the pailer shouldn't need 3rd party libraries, so I based this on > _.escape from underscore.js (although simplified to not have to consider > unescaping). > > > Diffs > ----- > > src/webui/master/static/jquery.pailer.js > 9bcaf01f48941ab75f1156ad27c6ff03d5ede68b > > Diff: https://reviews.apache.org/r/7854/diff/ > > > Testing > ------- > > Manually tested with local runs. > > > Screenshots > ----------- > > before > https://reviews.apache.org/r/7854/s/11/ > after > https://reviews.apache.org/r/7854/s/12/ > > > Thanks, > > Ben Mahler > >
