> On Nov. 5, 2012, 10:23 p.m., Benjamin Hindman wrote: > > src/Makefile.am, line 210 > > <https://reviews.apache.org/r/7769/diff/1/?file=181854#file181854line210> > > > > Is lxc_isolation_tests.cpp is gone too?
Yep, it was either never added to the Makefile, or was removed at some point.. > On Nov. 5, 2012, 10:23 p.m., Benjamin Hindman wrote: > > src/Makefile.am, line 215 > > <https://reviews.apache.org/r/7769/diff/1/?file=181854#file181854line215> > > > > The other lines probably have tabs instead of spaces. fixed. > On Nov. 5, 2012, 10:23 p.m., Benjamin Hindman wrote: > > src/slave/isolation_module_factory.cpp, line 30 > > <https://reviews.apache.org/r/7769/diff/1/?file=181860#file181860line30> > > > > This code is an island and should just get removed too. Can I kill common/factory.{hpp,cpp} as well? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7769/#review13106 ----------------------------------------------------------- On Oct. 29, 2012, 11:11 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7769/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2012, 11:11 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This removes the lxc isolation module! > > > Diffs > ----- > > src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f > src/launcher/launcher.hpp ead58c0f60b6bff532f241a224b547b25e292175 > src/launcher/launcher.cpp 3ce8081edba669157a14b815503322ea8d367d43 > src/launcher/main.cpp e90df85ae433431defdd251490c74a482a58f743 > src/slave/cgroups_isolation_module.cpp > a43d31760f14e641cc7d75b6e98041f98bba2b63 > src/slave/isolation_module.cpp a881bab582c30e2812bcdaf649a2e6458cc23c11 > src/slave/isolation_module_factory.cpp > 649894549f00c4ca231341ecaf2a8e5ab71d717c > src/slave/lxc_isolation_module.hpp 49bf8741b96f58202acb737917e6cc353e758893 > src/slave/lxc_isolation_module.cpp 36d86e08f7b511371a9a2053ddf43477063a79f1 > src/slave/process_based_isolation_module.cpp > 744832625d6d1898eb2b31b184f5d0c68408835d > src/tests/lxc_isolation_tests.cpp 30e7459069a75fecd3ea976ff02e7cf4f114089a > > Diff: https://reviews.apache.org/r/7769/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
