> On Nov. 13, 2012, 12:25 a.m., Vinod Kone wrote:
> > m4/python.m4, line 13
> > <https://reviews.apache.org/r/8026/diff/1/?file=188934#file188934line13>
> >
> > what are your modifications here?
I included a comment in the line below this one:
# I've modified this file to check for python2.6, of which automake <= 1.10
# is oblivious. As such, we can kill this file entirely if or when we decide
# to require automake >= 1.11.
Basically just adding python2.6 to the list:
m4_define_default([_AM_PYTHON_INTERPRETER_LIST],
[python python2 python2.6 python2.5 python2.4 python2.3 dnl
python2.2 python2.1 python2.0 python1.6 python1.5])
Let me know if you want more detail in the comment.
> On Nov. 13, 2012, 12:25 a.m., Vinod Kone wrote:
> > configure.ac, line 346
> > <https://reviews.apache.org/r/8026/diff/1/?file=188928#file188928line346>
> >
> > older or different?
> >
> > what if PYTHON=python2.7?
Yep, older.
PYTHON=python2.7 works
And the first thing it checks is what the version of the 'python' binary, which
on my mac is 2.7. This works as well.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8026/#review13374
-----------------------------------------------------------
On Nov. 13, 2012, 12:19 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8026/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2012, 12:19 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Now, configure.ac takes care of:
> -Detecting python >= 2.6 automatically (Added python.m4 from automake 1.10
> tweaked to include python2.6)
> -Linking with libunwind when present.
> -Including some special java include paths from the old configure.macosx
>
> python.m4 is only necessary if we intend to support automake 1.10.
> automake 1.11 is aware of python 2.7, whereas 1.10 is only aware of python
> 2.5.
>
>
> This addresses bug MESOS-285.
> https://issues.apache.org/jira/browse/MESOS-285
>
>
> Diffs
> -----
>
> configure.ac 990af15933e3b42ca822221ded1e6ae7e16ac85f
> configure.amazon-linux-64 716153358144395f78bcdddb0c8559d9691c27e9
> configure.centos-5.4-64 0a33ff0961ea6a9893a4e4aa738f53c48297bafe
> configure.macosx e9a80779367411f1a045143c2ed99f2d04c816f1
> configure.ubuntu-lucid-64 496c16201026ea7693a1674667fbf29ed2b3c570
> configure.ubuntu-natty-64 f940128ecfa4e6cdf9e22f9ebf48486ab5e01205
> m4/python.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/8026/diff/
>
>
> Testing
> -------
>
> Tested on OSX 10.7 and CentOS 5.
>
>
> Thanks,
>
> Ben Mahler
>
>
