----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7772/#review13468 -----------------------------------------------------------
src/log/replica.cpp <https://reviews.apache.org/r/7772/#comment28854> You're double printing the error (hence the desire for CHECK_SOME). src/master/main.cpp <https://reviews.apache.org/r/7772/#comment28853> You're double printing the error (hence the desire for CHECK_SOME). src/slave/main.cpp <https://reviews.apache.org/r/7772/#comment28855> Ditto. src/slave/paths.hpp <https://reviews.apache.org/r/7772/#comment28856> Ditto. src/slave/paths.hpp <https://reviews.apache.org/r/7772/#comment28857> Ditto. src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/7772/#comment28858> Ditto. src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/7772/#comment28859> Ditto. src/slave/state.cpp <https://reviews.apache.org/r/7772/#comment28860> Ditto. src/slave/state.cpp <https://reviews.apache.org/r/7772/#comment28861> Ditto. src/slave/state.cpp <https://reviews.apache.org/r/7772/#comment28862> Dittoish (need to kill 'strerror(errno)'). src/slave/state.cpp <https://reviews.apache.org/r/7772/#comment28863> Ditto. src/slave/state.cpp <https://reviews.apache.org/r/7772/#comment28864> Dittoish again. src/tests/flags.hpp <https://reviews.apache.org/r/7772/#comment28865> Ditto. src/tests/flags.hpp <https://reviews.apache.org/r/7772/#comment28866> Ditto. src/tests/script.cpp <https://reviews.apache.org/r/7772/#comment28867> Ditto. src/tests/slave_state_tests.cpp <https://reviews.apache.org/r/7772/#comment28868> Ditto. src/tests/utils.cpp <https://reviews.apache.org/r/7772/#comment28869> Ditto. src/zookeeper/group.cpp <https://reviews.apache.org/r/7772/#comment28870> Ditto. src/zookeeper/group.cpp <https://reviews.apache.org/r/7772/#comment28871> Ditto. src/zookeeper/group.cpp <https://reviews.apache.org/r/7772/#comment28872> Ditto. third_party/libprocess/include/process/future.hpp <https://reviews.apache.org/r/7772/#comment28848> This CHECK is for us, the library writers, so that we make sure that we always have transitioned a future out of pending after await. The errors below and the abort is because a programmer decided to call get and block, and while we should always transition out of pending after await the future might have failed and so we can't return any value. third_party/libprocess/include/process/http.hpp <https://reviews.apache.org/r/7772/#comment28849> I thought you check the digits above? (Hence the CHECK here). third_party/libprocess/include/stout/numify.hpp <https://reviews.apache.org/r/7772/#comment28852> In the meantime, why don't you like this CHECK? With the check we get a stack trace, which in this case will probably help us track down a bug (this doesn't seem like an instance where we want to have better output for our users, this is a legitimate crash). - Benjamin Hindman On Nov. 6, 2012, 11:55 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7772/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2012, 11:55 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This adds consistency with what we've done with ASSERT_SOME, EXPECT_SOME. > > > Diffs > ----- > > src/java/jni/org_apache_mesos_Log.cpp > e9ffccf8912977ff89cc5cb1ea1369ea5ce25647 > src/log/coordinator.cpp 31d48e901825b44de0b5e66394cd9020108b45b6 > src/log/log.hpp db026dc1edcf0bfe059dcff4036a1278d9933c26 > src/log/log.cpp fcc343ef0e7cab3152d49dd837ce4da0347c8cd8 > src/log/main.cpp 69d9443702e2ddf3b868957fe8f2712346a677de > src/log/replica.cpp b39623e8a9cb44cf4889b4d3351e952227810e54 > src/logging/logging.hpp 8e8a4f6f92644c4db2d0d59925a930b6f0f72961 > src/master/main.cpp 74c955f262179d52408d6b0eaada4d7801bcc193 > src/slave/main.cpp 70bb71e427aaa5e1ebb1ae132c9aad3ebe9be34c > src/slave/paths.hpp 98e7fd402919c50a26f69a2f1a1904cb877c5f43 > src/slave/process_based_isolation_module.cpp > b0b6a81c93acc68d1f4acbdda5ab2f9f96b5fb5a > src/slave/slave.cpp 2bd2dbce538a6108dd9fe607829cfbdab33e0778 > src/slave/state.cpp 65d91b889b84152ed12c4f2dd623b537242258df > src/tests/flags.hpp add9e0a1ec8c73e6556f9da2019e409edda305b3 > src/tests/script.cpp 783b369db44ab73132cc0b7d22a3c1f4d1928fda > src/tests/slave_state_tests.cpp 7d09507d37f41c77f32ec04c7ecfc9657f196a30 > src/tests/utils.cpp deef0bba1374cf8a8591813877a6170974d6de94 > src/zookeeper/group.cpp 876b2ce4e94bfe45902ef86c3143b68ff30029f0 > third_party/libprocess/include/process/future.hpp > 49767c57c45f2a4d5c293b1ce0dcef3e40ab2e9f > third_party/libprocess/include/process/http.hpp > f8d0a5886c77eaf885732346b89be326e89afad6 > third_party/libprocess/include/stout/numify.hpp > 9f49e80c4f4d366264a699b12f84fc114f2dfe6a > > Diff: https://reviews.apache.org/r/7772/diff/ > > > Testing > ------- > > CentOS: make check > > > Thanks, > > Ben Mahler > >
