----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8055/#review13438 -----------------------------------------------------------
Ship it! modulo fixture naming src/tests/allocator_tests.cpp <https://reviews.apache.org/r/8055/#comment28955> Let's still call this AllocatorTest? Looking at the primer that seems to be the convention: http://code.google.com/p/googletest/wiki/Primer src/tests/allocator_tests.cpp <https://reviews.apache.org/r/8055/#comment28956> Hm.. so what's the difference between this AllocatorTest fixture and the AllocatorTestFixture fixture? Maybe name the tests appropriately to show the difference? src/tests/fault_tolerance_tests.cpp <https://reviews.apache.org/r/8055/#comment28958> src/tests/master_tests.cpp <https://reviews.apache.org/r/8055/#comment28959> ditto fixture name: s/WhitelistFixture/MasterWhitelistTest? src/tests/resource_offers_tests.cpp <https://reviews.apache.org/r/8055/#comment28960> s/ResourceOffersTestFixture/ResourceOffersTest src/tests/utils.hpp <https://reviews.apache.org/r/8055/#comment28796> Too bad my CHECK_SOME is not submitted ;) - Ben Mahler On Nov. 14, 2012, 7:20 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8055/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2012, 7:20 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > I envisage this new test fixture to do a lot more than creating/deleting > working directories. But thats probably for another review. > > > Diffs > ----- > > src/tests/allocator_tests.cpp 44d72ad2b746b1b7032f8243817a6002100a7503 > src/tests/allocator_zookeeper_tests.cpp > 5f83dd71aa3cac1dd3727b65af087f651f961392 > src/tests/configurator_tests.cpp 91c01ad19c23a3f7b1e0e0c369e8d6d9fa534dc5 > src/tests/fault_tolerance_tests.cpp > 7c3d155479a4f7fda5c14f62909eea5f5a1a92df > src/tests/master_detector_tests.cpp > 5d09babc728d7922e47204290e86943179a34226 > src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed > src/tests/resource_offers_tests.cpp > 5981191597e673c47be331420b71be66456694c6 > src/tests/utils.hpp cc1a81d07c6f23e3e2590c2df485f18d114cc6a6 > src/tests/zookeeper_test.hpp 2aa105fed170b2824040a79bd450129f06c4bc13 > src/tests/zookeeper_test.cpp 4bd6a293c177864b8767c876ccd91e7cbb0f84f0 > > Diff: https://reviews.apache.org/r/8055/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
