> On Nov. 19, 2012, 9:53 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 1145-1150 > > <https://reviews.apache.org/r/8128/diff/1/?file=221867#file221867line1145> > > > > Why not always forward this to the scheduler, irrespective of whether > > the master knows about slaveId/ executorId/frameworkId?
Master needs to know about the frameworkId to know the scheduler PID to forward to, but, removed requirement to know slave. > On Nov. 19, 2012, 9:53 p.m., Vinod Kone wrote: > > src/sched/sched.cpp, line 406 > > <https://reviews.apache.org/r/8128/diff/1/?file=221868#file221868line406> > > > > s/on/on slave/ Done. - Charles ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8128/#review13588 ----------------------------------------------------------- On Nov. 19, 2012, 10:09 p.m., Charles Reiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8128/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2012, 10:09 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > Forward ExitedExecutorMessages from the master to framework schedulers, and > call Scheduler::executorLost when they are received. > > > This addresses bug MESOS-313. > https://issues.apache.org/jira/browse/MESOS-313 > > > Diffs > ----- > > src/master/master.cpp 87fad0e > src/sched/sched.cpp a1247f9 > src/tests/gc_tests.cpp 6b3ba02 > src/tests/master_tests.cpp 948ab5d > > Diff: https://reviews.apache.org/r/8128/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Charles Reiss > >
