----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7212/#review14071 -----------------------------------------------------------
src/common/protobuf_utils.hpp <https://reviews.apache.org/r/7212/#comment30085> Do you need ::process? src/slave/status_updates_manager.hpp <https://reviews.apache.org/r/7212/#comment30086> s/"s/<s/g s/p"/p>/g src/slave/status_updates_manager.hpp <https://reviews.apache.org/r/7212/#comment30087> Not in the header please. src/slave/status_updates_manager.hpp <https://reviews.apache.org/r/7212/#comment30088> s/(SUM)// src/slave/status_updates_manager.hpp <https://reviews.apache.org/r/7212/#comment30089> Formatting (here and everywhere else). src/slave/status_updates_manager.hpp <https://reviews.apache.org/r/7212/#comment30090> Kill for now, recover (pun intended) in part four. src/slave/status_updates_manager.cpp <https://reviews.apache.org/r/7212/#comment30091> s/"s/<s/g s/p"/p>/g src/slave/status_updates_manager.cpp <https://reviews.apache.org/r/7212/#comment30093> Kill, see below. src/slave/status_updates_manager.cpp <https://reviews.apache.org/r/7212/#comment30092> Check this here, and return if error. src/slave/status_updates_manager.cpp <https://reviews.apache.org/r/7212/#comment30097> return true; ? src/slave/status_updates_manager.cpp <https://reviews.apache.org/r/7212/#comment30101> Move to StatusUpdateStream (call it write? or checkpoint?). src/slave/status_updates_manager.cpp <https://reviews.apache.org/r/7212/#comment30100> Formatting. src/slave/status_updates_manager.cpp <https://reviews.apache.org/r/7212/#comment30102> s/recordType/type/ src/slave/status_updates_manager.cpp <https://reviews.apache.org/r/7212/#comment30103> Let's do this in stream. src/slave/status_updates_manager.cpp <https://reviews.apache.org/r/7212/#comment30105> Reorder. src/slave/status_updates_manager.cpp <https://reviews.apache.org/r/7212/#comment30106> Just call it process, that's the standard other places. third_party/libprocess/include/process/timeout.hpp <https://reviews.apache.org/r/7212/#comment30107> ? - Benjamin Hindman On Dec. 3, 2012, 9:54 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7212/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2012, 9:54 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > added shutdownFramework > > > Minor fixes for open > > > Ben's comments > > > Refactoring SUM > > > Bens' comments > > > Status Update Manager > > Rebased off latest trunk > > Conflicts: > src/Makefile.am > src/common/protobuf_utils.hpp > src/common/utils.hpp > src/slave/slave.cpp > src/tests/protobuf_io_tests.cpp > src/tests/utils_tests.cpp > > > Diffs > ----- > > src/Makefile.am cf9364ea0418ec30a75b1774f32bda8de6e031ac > src/common/protobuf_utils.hpp 77b300d7c1a02a836100d3365e205889c48ae99a > src/messages/messages.proto 4e0538fe929f9091e5cdd4a1bb017d836df52a3e > src/slave/status_updates_manager.hpp PRE-CREATION > src/slave/status_updates_manager.cpp PRE-CREATION > third_party/libprocess/include/process/timeout.hpp > cac996070359a3e7ecdd8077af83c8c4cf9735fd > > Diff: https://reviews.apache.org/r/7212/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Vinod Kone > >
