> On Dec. 6, 2012, 12:48 a.m., Benjamin Hindman wrote: > > src/slave/slave.cpp, line 643 > > <https://reviews.apache.org/r/7655/diff/3/?file=233869#file233869line643> > > > > TASK_LOST or TASK_KILLED?
i think TASK_KILLED makes sense actually. reverted > On Dec. 6, 2012, 12:48 a.m., Benjamin Hindman wrote: > > src/slave/slave.cpp, line 519 > > <https://reviews.apache.org/r/7655/diff/3/?file=233869#file233869line519> > > > > Explain why not using statusUpdate directly. fixed with explanation. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7655/#review14074 ----------------------------------------------------------- On Dec. 4, 2012, 3:59 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7655/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2012, 3:59 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Integrated SUM into slave. > > > Diffs > ----- > > include/mesos/mesos.proto 38235157d45bdccb676e5c3241c21b585a6f8801 > src/Makefile.am b2d1edf140797c7150cb4644d323296965c4f000 > src/messages/messages.proto 815fcbbcb4a8643f50950a294cedf7281b2a187f > src/slave/gc.cpp 679504e51922c5ea54a476d061262e8e8f2aa4b6 > src/slave/paths.hpp 98e7fd402919c50a26f69a2f1a1904cb877c5f43 > src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba > src/slave/slave.cpp 28fd4c336d8ac658cf92811d20066a6cfdf5a95e > src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed > src/tests/status_updates_manager_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/7655/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
