> On Dec. 13, 2012, 7:33 p.m., Ben Mahler wrote: > > src/messages/messages.proto, line 263 > > <https://reviews.apache.org/r/8535/diff/2/?file=237636#file237636line263> > > > > Again, I'm scared about adding required fields.
lets get back to this when we have all the slave recovery in place. > On Dec. 13, 2012, 7:33 p.m., Ben Mahler wrote: > > src/slave/cgroups_isolation_module.cpp, line 433 > > <https://reviews.apache.org/r/8535/diff/2/?file=237638#file237638line433> > > > > I know it's the same but given what you're checking I think it's > > clearer to leave the logic to read literally as your message reads: > > > > !(checkpoint && path.isNone()) > > > > or > > > > if (checkpoint) { > > CHECK_SOME(path) << "Blah"; > > } sure. i like the first one better. > On Dec. 13, 2012, 7:33 p.m., Ben Mahler wrote: > > src/slave/cgroups_isolation_module.cpp, line 528 > > <https://reviews.apache.org/r/8535/diff/2/?file=237638#file237638line528> > > > > Use CHECK_SOME (you don't need to store the write result if you don't > > like). > > Change the message to use the 'failed' format. > > > > CHECK_SOME(os::write(path.get(), stringify(getpid()))) > > << "Failed to checkpoint forked pid " << add pid to message? done. btw, checkpointing is now moved into slave/state.cpp > On Dec. 13, 2012, 7:33 p.m., Ben Mahler wrote: > > src/slave/slave.hpp, line 213 > > <https://reviews.apache.org/r/8535/diff/2/?file=237645#file237645line213> > > > > With checkpointing enabled, will the slave id stay the same across > > recovered rolling of the slave? yes! > On Dec. 13, 2012, 7:33 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 515 > > <https://reviews.apache.org/r/8535/diff/2/?file=237646#file237646line515> > > > > Do we end these messages with periods? no we don't - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8535/#review14456 ----------------------------------------------------------- On Dec. 12, 2012, 11:16 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8535/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2012, 11:16 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Checkpoints slave id, framework pid, executor pids (libprocess, execed, > forked) and task info. > > > Diffs > ----- > > src/exec/exec.cpp 821a94fab1f5969183ecf9e28d7b6bc10920db24 > src/messages/messages.proto 815fcbbcb4a8643f50950a294cedf7281b2a187f > src/slave/cgroups_isolation_module.hpp > 669efa14ba2603764aa68ae19a44e79dbfdec192 > src/slave/cgroups_isolation_module.cpp > 0f2975d1adf874dba4d0a539eb5c99233cef6e6b > src/slave/flags.hpp 39e57f4104ee7a1538436ebbb9493581e28c99dd > src/slave/isolation_module.hpp b962365ebeddd047896a66b02a327aa26ae323d3 > src/slave/lxc_isolation_module.hpp 2bc844f491befbe588965da2ada7cfcef0b6f0a4 > src/slave/lxc_isolation_module.cpp 30cff2a49339bb07030727d30352536a0a22d58c > src/slave/process_based_isolation_module.hpp > f1817192582e3646f8dcf17934ba7998829e8fd6 > src/slave/process_based_isolation_module.cpp > 3d50a4b652e4e09dd57e744e408c8fb79ff3fbf5 > src/slave/slave.hpp e9f7b659ca2860501840b3d01e69915ebd162039 > src/slave/slave.cpp 9755b46f97173d6fcc9ab1fd63e0e4814b3bc018 > src/tests/protobuf_io_tests.cpp 979efac0f28c3d361f5c347f15933d89d9356bc9 > src/tests/status_update_manager_tests.cpp PRE-CREATION > src/tests/utils.hpp be457117515ee727af101370b26bf9188afb8f45 > > Diff: https://reviews.apache.org/r/8535/diff/ > > > Testing > ------- > > make check > > Will write new tests as part of Part 5, when I write the analogous > read/replay functions of the checkpoint functions. > > > Thanks, > > Vinod Kone > >
