> On Dec. 13, 2012, 2:42 a.m., Ben Mahler wrote: > > See my previous comment, have you considered mesos-local in these changes? > > In that, is there anything that breaks mesos-local?
as i responded above, it should be fixed now. > On Dec. 13, 2012, 2:42 a.m., Ben Mahler wrote: > > src/slave/status_update_manager.hpp, line 180 > > <https://reviews.apache.org/r/7212/diff/9/?file=237623#file237623line180> > > > > Looks like you also need a CHECK(result.get()) after since this can > > return false. > > Vinod Kone wrote: > I didn't want to write to CHECK's with similar looking error messages, so > I changed CHECK_SOME to CHECK(result.isSome() && result.get(). > > Need to do some ternary operator trickery in the log output, though. Let > me know what you think. s/write to/write two/ s/Need/Needed/ - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7212/#review14417 ----------------------------------------------------------- On Dec. 12, 2012, 11:11 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7212/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2012, 11:11 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > added shutdownFramework > > > Minor fixes for open > > > Ben's comments > > > Refactoring SUM > > > Bens' comments > > > Status Update Manager > > Rebased off latest trunk > > Conflicts: > src/Makefile.am > src/common/protobuf_utils.hpp > src/common/utils.hpp > src/slave/slave.cpp > src/tests/protobuf_io_tests.cpp > src/tests/utils_tests.cpp > > > Diffs > ----- > > src/Makefile.am c94736df660a25b58dc47c07d9c56c3c26152a66 > src/common/protobuf_utils.hpp 69baab78c8db2d2d33ffbbe7f5e5fc80d65b0e1a > src/common/type_utils.hpp fde69aeec403b3455839dca6b0b2e1507d81ba00 > src/messages/messages.proto 815fcbbcb4a8643f50950a294cedf7281b2a187f > src/slave/status_update_manager.hpp PRE-CREATION > src/slave/status_update_manager.cpp PRE-CREATION > third_party/libprocess/include/process/timeout.hpp > cac996070359a3e7ecdd8077af83c8c4cf9735fd > > Diff: https://reviews.apache.org/r/7212/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Vinod Kone > >
