----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8453/#review14765 -----------------------------------------------------------
Ship it! third_party/libprocess/include/process/profiler.hpp <https://reviews.apache.org/r/8453/#comment31289> I wonder if to be more robust we'll want to specify a full path, that way if there are any bad 'chdir' calls in the code this will always work. - Benjamin Hindman On Dec. 12, 2012, 8:32 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8453/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2012, 8:32 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This adds the following endpoints to libprocess: > > '/profiler/start': Starts the profiler via ProfilerStart() > '/profiler/stop': Stops the profiler via ProfilerStop(), also returns the > output file. > > This allows profiling libprocess on the fly. > Note that it's not considered stable on 64 bit systems, due to issues with > libunwind and glibc. > > > Diffs > ----- > > third_party/libprocess/Makefile.am 6b68c69b07b831255d34a68d7b9b4b37eee55167 > third_party/libprocess/include/process/http.hpp > ced8c1ab69952c4297d92b472f8d3edb5954105c > third_party/libprocess/include/process/profiler.hpp PRE-CREATION > third_party/libprocess/src/process.cpp > e408ca9274f1253e3e67c656561a9366dd2bce33 > > Diff: https://reviews.apache.org/r/8453/diff/ > > > Testing > ------- > > Profiled using mesos-local and examined output. > > FWIW I didn't observe any crashes, but I've only profiled with mesos-local > and for O(minutes). > > > Thanks, > > Ben Mahler > >
