----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8796/#review15041 -----------------------------------------------------------
IIRC, putting 'stout' inside libprocess was a stop-gap plan. We eventually want to pull out stout as its own independent library (and open source it!). I think this is a good time do that refactor. Even if we don't want to the above refactor now, I'm wary about pulling stout_tests.cpp apart this way because it would make it difficult to find stout specific test files when we eventually want to make stout its own library. - Vinod Kone On Jan. 2, 2013, 2:45 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8796/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2013, 2:45 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This is part 5 of my refactoring to pull apart libprocess / stout tests. > > This is the final part, which pulls apart the stout tests. > This makes it easier to spot where our test coverage is insufficient. > There are no real diffs on these *tests.cpp files, since I just pulled the > contents of stout_tests.cpp apart. > > > Diffs > ----- > > src/Makefile.am 0ab59b75b2955c532d0833f132bdaffe323838d0 > src/tests/multihashmap_tests.cpp 4073e9db947b6a4fca2064c88fe6e37bbe720383 > third_party/libprocess/Makefile.am 11f8b36d19313f65f1b191a781c6d5ed90130099 > third_party/libprocess/src/tests/duration_tests.cpp PRE-CREATION > third_party/libprocess/src/tests/gzip_tests.cpp PRE-CREATION > third_party/libprocess/src/tests/hashset_tests.cpp PRE-CREATION > third_party/libprocess/src/tests/json_tests.cpp PRE-CREATION > third_party/libprocess/src/tests/multihashmap_tests.cpp PRE-CREATION > third_party/libprocess/src/tests/os_tests.cpp PRE-CREATION > third_party/libprocess/src/tests/stout_tests.cpp PRE-CREATION > third_party/libprocess/src/tests/strings_tests.cpp PRE-CREATION > third_party/libprocess/src/tests/uuid_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/8796/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
