----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8798/#review15047 -----------------------------------------------------------
Ship it! third_party/libprocess/src/encoder.hpp <https://reviews.apache.org/r/8798/#comment32601> Looks like moving it inside Request is better. third_party/libprocess/src/tests/decoder_tests.cpp <https://reviews.apache.org/r/8798/#comment32602> its hard to tell whether the spaces match. its probably better to just split and check the contents of "Accept-Encoding"? - Vinod Kone On Jan. 2, 2013, 2:54 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8798/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2013, 2:54 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See above. > > > Diffs > ----- > > third_party/libprocess/Makefile.am 11f8b36d19313f65f1b191a781c6d5ed90130099 > third_party/libprocess/include/process/http.hpp > 40248dab3df59b322ad9c5a4858961ef471779fd > third_party/libprocess/src/decoder.hpp > 253824f964845c8b7c9c29f31301b5b6c2c4a2f1 > third_party/libprocess/src/encoder.hpp > 9664f38b7b972f196921ef13adb8c9caa180ca65 > third_party/libprocess/src/process.cpp > 72e437862ee0b35126c16d32bec79ef76a4e2b23 > third_party/libprocess/src/tests/decoder_tests.cpp PRE-CREATION > third_party/libprocess/src/tests/main.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/8798/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
