> On Jan. 15, 2013, 7:03 a.m., Vinod Kone wrote: > > src/launcher/launcher.cpp, line 89 > > <https://reviews.apache.org/r/8947/diff/2/?file=248379#file248379line89> > > > > s/framework/executor/
Fixed here and elsewhere. > On Jan. 15, 2013, 7:03 a.m., Vinod Kone wrote: > > src/launcher/launcher.cpp, lines 302-310 > > <https://reviews.apache.org/r/8947/diff/2/?file=248379#file248379line302> > > > > Doesn't look this is need any more, now that you chown "." below? I think this is still needed because of the chmod following it. If we don't chown it we'll get the chmod permissions wrong, no? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8947/#review15341 ----------------------------------------------------------- On Jan. 15, 2013, 2:42 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8947/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2013, 2:42 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > Executes 'chown -R user:group .' while in the work directory, in order to > chown the extracted executor resources. > > For some chown subtlety: http://aplawrence.com/Unixart/chown.html > > > This addresses bug MESOS-332. > https://issues.apache.org/jira/browse/MESOS-332 > > > Diffs > ----- > > src/launcher/launcher.cpp 3ce8081edba669157a14b815503322ea8d367d43 > third_party/libprocess/include/stout/os.hpp > 5b5b33636cb396c3324ab7f3f42144f4ab30ef95 > > Diff: https://reviews.apache.org/r/8947/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
