----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9090/#review15761 -----------------------------------------------------------
Ship it! third_party/libprocess/src/process.cpp <https://reviews.apache.org/r/9090/#comment33921> We don't want libraries to automatically spit log messages. In other words, we prefer VLOG so that users can specifically request them (by setting GLOG_v) if they are so interested. - Vinod Kone On Jan. 24, 2013, 9:02 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9090/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2013, 9:02 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This adds a global Statistics object for libprocess, which enables > centralized stats across Processes. > > I'd love to eventually plumb stats into libprocess and export to the webui! > (MESOS-320) > > > This addresses bug MESOS-324. > https://issues.apache.org/jira/browse/MESOS-324 > > > Diffs > ----- > > third_party/libprocess/include/process/statistics.hpp > 9e3041a6e2a8ef022eacacad00bc4d974a8e33c9 > third_party/libprocess/src/process.cpp > 72e437862ee0b35126c16d32bec79ef76a4e2b23 > third_party/libprocess/src/statistics.cpp > 2fe8af83c6c63a0fa8cb2e9636f9289f0e3d7f2f > > Diff: https://reviews.apache.org/r/9090/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
