----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9091/#review15763 -----------------------------------------------------------
third_party/libprocess/src/statistics.cpp <https://reviews.apache.org/r/9091/#comment33923> Why virtual? Are you expecting this to be subclassed? third_party/libprocess/src/statistics.cpp <https://reviews.apache.org/r/9091/#comment33924> What if context doesn't exist? third_party/libprocess/src/statistics.cpp <https://reviews.apache.org/r/9091/#comment33925> ditto third_party/libprocess/src/statistics.cpp <https://reviews.apache.org/r/9091/#comment33926> kinda weird to the name of the iterator that traverses the whole map as 'start'? s/start/it? third_party/libprocess/src/statistics.cpp <https://reviews.apache.org/r/9091/#comment33927> so is it ok to mutate the list and use its iterator at the same time!? - Vinod Kone On Jan. 24, 2013, 9:06 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9091/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2013, 9:06 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This adds context into the Statistics model. Contexts provide a clean way to > logically group stats (e.g. contexts: "master", "slave", "monitor", > "libprocess", etc). > > > This addresses bug MESOS-324. > https://issues.apache.org/jira/browse/MESOS-324 > > > Diffs > ----- > > third_party/libprocess/include/process/statistics.hpp > 9e3041a6e2a8ef022eacacad00bc4d974a8e33c9 > third_party/libprocess/src/statistics.cpp > 2fe8af83c6c63a0fa8cb2e9636f9289f0e3d7f2f > third_party/libprocess/src/statistics_tests.cpp > 0aaab3526618171c7cfbd11d40d614344bcbfd0a > > Diff: https://reviews.apache.org/r/9091/diff/ > > > Testing > ------- > > make check + libprocess make check > > > Thanks, > > Ben Mahler > >
