----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8762/ -----------------------------------------------------------
(Updated Jan. 29, 2013, 11:08 p.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Changes ------- changes based on addressing some upstream reviews. NOTE: I had to disable couple of slave recovery tests, because we no longer consider the recovery non-fatal in the cases setup by those tests. Description ------- Properly recovers and reconnects with executors. Also, recovers isolation module. This is pretty much the whole of recovery! (I'm going to send out another tiny review for properly doing incompatible upgrades) Diffs (updated) ----- src/exec/exec.cpp 821a94fab1f5969183ecf9e28d7b6bc10920db24 src/launcher/launcher.hpp ead58c0f60b6bff532f241a224b547b25e292175 src/launcher/launcher.cpp f2d68c5fd1201b75c5a8f96599d7fb36516687fb src/launcher/main.cpp e90df85ae433431defdd251490c74a482a58f743 src/messages/messages.proto 815fcbbcb4a8643f50950a294cedf7281b2a187f src/slave/cgroups_isolation_module.hpp 669efa14ba2603764aa68ae19a44e79dbfdec192 src/slave/cgroups_isolation_module.cpp 63cefc33cf34eebb82db5d8448b751be8652fa36 src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 src/slave/isolation_module.hpp b962365ebeddd047896a66b02a327aa26ae323d3 src/slave/lxc_isolation_module.hpp 2bc844f491befbe588965da2ada7cfcef0b6f0a4 src/slave/lxc_isolation_module.cpp 30cff2a49339bb07030727d30352536a0a22d58c src/slave/process_based_isolation_module.hpp f1817192582e3646f8dcf17934ba7998829e8fd6 src/slave/process_based_isolation_module.cpp 3d50a4b652e4e09dd57e744e408c8fb79ff3fbf5 src/slave/slave.hpp e9f7b659ca2860501840b3d01e69915ebd162039 src/slave/slave.cpp 9755b46f97173d6fcc9ab1fd63e0e4814b3bc018 src/slave/state.cpp 4d4c2470c44fe630ec0694ee937131b4f0aafc4e src/slave/status_update_manager.cpp PRE-CREATION src/tests/slave_recovery_tests.cpp PRE-CREATION src/tests/utils.hpp be457117515ee727af101370b26bf9188afb8f45 Diff: https://reviews.apache.org/r/8762/diff/ Testing ------- make check Thanks, Vinod Kone
