----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9120/#review15820 -----------------------------------------------------------
Ship it! actually, i do think the vertical alignment looks better. - Vinod Kone On Jan. 28, 2013, 5:23 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9120/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2013, 5:23 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See MESOS-273. > > I'm also using Bytes in: https://reviews.apache.org/r/9121/ > > I also made some whitespace changes in duration.hpp, mostly to generate > discussion around vertical alignment when appropriate. > > > This addresses bug MESOS-273. > https://issues.apache.org/jira/browse/MESOS-273 > > > Diffs > ----- > > src/tests/stout_tests.cpp c352066f60a68208397651d887da40cbd5fc37f3 > third_party/libprocess/Makefile.am 11f8b36d19313f65f1b191a781c6d5ed90130099 > third_party/libprocess/include/stout/bytes.hpp PRE-CREATION > third_party/libprocess/include/stout/duration.hpp > caf7ce42b34dfb74206d1f10aafabaaec47e7dfc > > Diff: https://reviews.apache.org/r/9120/diff/ > > > Testing > ------- > > Added tests, make check. > > > Thanks, > > Ben Mahler > >
