> On Jan. 30, 2013, 8:22 p.m., Benjamin Hindman wrote: > > Duplicating assert.hpp in both places is not a good long term strategy and > > I'd like us to address this now rather than later.
Agreed. I hesitated to do the following: -push assert.hpp into stout headers -stout/assert.hpp only contains non-Future EXPECT/ASSERTs -push assert.hpp into process headers -process/assert.hpp only contains Future EXPECT/ASSERTs Although in retrospect I should have done that, agreed? Other ideas? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8794/#review15883 ----------------------------------------------------------- On Jan. 29, 2013, 1:55 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8794/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2013, 1:55 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This is part 3 of my test refactorings to pull apart the libprocess / stout > tests. > > This moves the stout tests into third_party/libprocess/tests. > I added an assert.hpp file as well so that the libprocess tests can share the > ASSERT_SOME style asserts. > There are no actual diffs to the test file contents. > > > Diffs > ----- > > src/Makefile.am 0ab59b75b2955c532d0833f132bdaffe323838d0 > src/tests/stout_tests.cpp c352066f60a68208397651d887da40cbd5fc37f3 > third_party/libprocess/Makefile.am 11f8b36d19313f65f1b191a781c6d5ed90130099 > third_party/libprocess/src/tests/assert.hpp PRE-CREATION > third_party/libprocess/src/tests/stout_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/8794/diff/ > > > Testing > ------- > > make check > cd third_party/libprocess > make check > > > Thanks, > > Ben Mahler > >
