> On Jan. 30, 2013, 8:55 p.m., Benjamin Hindman wrote: > > src/python/setup.py.in, line 24 > > <https://reviews.apache.org/r/9020/diff/2/?file=250292#file250292line24> > > > > Let's get the gperftools from libprocess/third_party, just like we do > > from libev below. In fact, let's just move this line down by the libev line > > and update the comment to reflect the how/why of including both libev and > > gperftools. > > > > A nice side effect here is we can kill the tarball from Mesos > > third_party! One more step to eliminating the redundant tarballs.
Thanks and done! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9020/#review15886 ----------------------------------------------------------- On Jan. 18, 2013, 11:52 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9020/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2013, 11:52 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This fixes a regression in the python tests to the the addition of gperftools. > > > Diffs > ----- > > src/Makefile.am 0ab59b75b2955c532d0833f132bdaffe323838d0 > src/python/setup.py.in a564cd8a0664a962bc71fc63f2a873737c275a8e > > Diff: https://reviews.apache.org/r/9020/diff/ > > > Testing > ------- > > make check (on OSX & Linux) > > > Thanks, > > Ben Mahler > >
