> On Jan. 31, 2013, 7:07 p.m., Vinod Kone wrote: > > src/linux/cgroups.hpp, line 345 > > <https://reviews.apache.org/r/9145/diff/1/?file=253216#file253216line345> > > > > since you are reading multiple stats > > s/stat/stats/ ?
I wanted to name this primitive stat because, it reads stat files: -cpuacct.stat -memory.stat So "stat" seems like the natural name for this primitive. > On Jan. 31, 2013, 7:07 p.m., Vinod Kone wrote: > > src/slave/cgroups_isolation_module.cpp, line 618 > > <https://reviews.apache.org/r/9145/diff/1/?file=253219#file253219line618> > > > > Is "ticks <= 0" something fatal? Good point, I think it's fatal since the only errno is: EINVAL: The value of the name argument is invalid. > On Jan. 31, 2013, 7:07 p.m., Vinod Kone wrote: > > src/slave/cgroups_isolation_module.cpp, line 631 > > <https://reviews.apache.org/r/9145/diff/1/?file=253219#file253219line631> > > > > What does it mean for the map to contain timestamp and executor info, > > but no stats? Is that OK? Would you rather not have a map entry? I'd like to have an entry for each executor. These entries could be missing resource usage, but I'd rather that information bubble up to the ui / stats, rather than stay hidden completely. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9145/#review15956 ----------------------------------------------------------- On Jan. 30, 2013, 4:07 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9145/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2013, 4:07 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This implements resource collection for the cgroups isolation module. > > > This addresses bug MESOS-324. > https://issues.apache.org/jira/browse/MESOS-324 > > > Diffs > ----- > > src/linux/cgroups.hpp 1f701f3bbbe06ddf84768c68b529aba4659c19be > src/linux/cgroups.cpp 03b31e7309b9dd65f00d3b0da2abb81ddaaeea43 > src/slave/cgroups_isolation_module.hpp > 669efa14ba2603764aa68ae19a44e79dbfdec192 > src/slave/cgroups_isolation_module.cpp > 63cefc33cf34eebb82db5d8448b751be8652fa36 > src/tests/cgroups_tests.cpp b219906374764e91f1a5268469ae92dd0fe08e53 > > Diff: https://reviews.apache.org/r/9145/diff/ > > > Testing > ------- > > Added tests for cgroups::stat. > > End to end testing using the webui. > > > Thanks, > > Ben Mahler > >
