> On Feb. 5, 2013, 10:08 p.m., Vinod Kone wrote:
> > src/webui/master/static/slave_executor.html, line 72
> > <https://reviews.apache.org/r/9269/diff/1/?file=254925#file254925line72>
> >
> > where is this dataSize defined?
Inside app.js, it is a custom filter I created:
<snip>
.filter('dataSize', function() {
return function(bytes) {
if (bytes === null || bytes === undefined || isNaN(bytes)) {
return '';
} else if (bytes < 1024) {
return bytes.toFixed() + ' B';
} else if (bytes < (1024 * 1024)) {
return (bytes / 1024).toFixed() + ' KB';
} else if (bytes < (1024 * 1024 * 1024)) {
return (bytes / (1024 * 1024)).toFixed() + ' MB';
} else {
return (bytes / (1024 * 1024 * 1024)).toFixed() + ' GB';
}
}
})
</snip>
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9269/#review16139
-----------------------------------------------------------
On Feb. 2, 2013, 2:24 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9269/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2013, 2:24 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Added basic monitoring information into the webui.
>
> Later, we will want to add the ability to see timeseries.
>
>
> This addresses bug MESOS-99.
> https://issues.apache.org/jira/browse/MESOS-99
>
>
> Diffs
> -----
>
> src/webui/master/static/controllers.js
> f3777083883fce269ec23cbaf145203ecfde158a
> src/webui/master/static/slave_executor.html
> bd06e69b3c99a0a44993c31429d877914b644a1d
> src/webui/master/static/slave_framework.html
> c66150ecb794300239c92ceaf684bfd3f1cb007e
>
> Diff: https://reviews.apache.org/r/9269/diff/
>
>
> Testing
> -------
>
> manual webui testing
>
>
> Thanks,
>
> Ben Mahler
>
>
