> On Feb. 5, 2013, 9:48 p.m., Vinod Kone wrote: > > src/Makefile.am, lines 398-399 > > <https://reviews.apache.org/r/9267/diff/1/?file=254914#file254914line398> > > > > can you pull the versions out to thirdparty/versions.am, like we do > > with other packages?
I wouldn't call this a package, this is more of an "asset". All the webui assets are buried within webui/master/static/... and so are not part of third_party, so this would require a lot of refactoring, no? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9267/#review16137 ----------------------------------------------------------- On Feb. 2, 2013, 2:20 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9267/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2013, 2:20 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > I wanted to upgrade underscore.js in order to use the new _.object function. > > > Diffs > ----- > > src/Makefile.am c94736df660a25b58dc47c07d9c56c3c26152a66 > src/webui/master/static/index.html 39f5b6a50abc4c7c0b747afa3a1a834bdd715f83 > src/webui/master/static/pailer.html > 5ede77fe241653bc67a3a205abea5290fd73e311 > src/webui/master/static/underscore-1.3.3.min.js > 5a0cb3b008d213ef3ecd3147c51eed08d98e2c54 > src/webui/master/static/underscore-1.4.3.js PRE-CREATION > src/webui/master/static/underscore-1.4.3.min.js PRE-CREATION > > Diff: https://reviews.apache.org/r/9267/diff/ > > > Testing > ------- > > manual webui testing > > > Thanks, > > Ben Mahler > >
