> On Feb. 7, 2013, 1:06 a.m., Ben Mahler wrote: > > We tend to use the past tense: "Fixed comment typo in slave/constants.hpp" > > > > I like the spirit of doing small reviews, we constantly try to break our > > changes up into small chunks. > > Ben H wrote a tool to make this easier: > > https://github.com/bmahler/post-reviews > > > > However, for the next time, creating two separate typo fix reviews is > > probably too fine-grained ;) > > > > Glancing at the other changes, I would have grouped all the GCC 4.7 build > > fix changes into one review as well. > > I'd say they are a logical "chunk" of small changes, related to fixing > > MESOS-271.
Yeah, I realized this very shortly after noticing 8x amount of process that was created from this. Thanks for the feedback. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9322/#review16231 ----------------------------------------------------------- On Feb. 6, 2013, 4:37 a.m., David Mackey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9322/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2013, 4:37 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Fix typo in constants.hpp > > > Diffs > ----- > > src/slave/constants.hpp ddf0257 > > Diff: https://reviews.apache.org/r/9322/diff/ > > > Testing > ------- > > > Thanks, > > David Mackey > >
