[Dropping general@incubator no need for CC] Hi Vinod,
On 2/10/13 12:46 PM, "Vinod Kone" <[email protected]> wrote: >Hi Chris, > >I wanted the ability to mark someone's review as committed, once I apply >their patch to the trunk. This way the user would know that their patch >has >been committed. No worries. Here's the deal though -- that's not a good practice to follow. Here's why. Folks earn merit at Apache through their meritocracy, that is their contributions. So, it's important if someone submitted a patch to Review through ReviewBoard, that they have the ability to mark their own patch as committed. They can find this out in a number of ways, e.g., if the JIRA issue associated with the RB is closed. If the JIRA issue id is mentioned in the SVN or Git commit and if that contributor (not yet PPMC member) is following the commits@ list, etc. > Ben Hindman, Mesos project lead, follows this practice. So, >I thought, as a new committer, I could do the same. At Apache, we are all individuals and there is no "project lead" title :) Ben may be a prolific Mesos contributor (which I'm sure he is), but there are no project leads here. We have (P)PMCs, committers, contributors, etc. PPMC only exists in Incubator terminology. Once Mesos is a TLP, we have a PMC chair (also called a "Vice President"), but even that person isn't the project lead. No biggie, just wanted to correct that terminology since it can lead others to have the wrong impression that projects at Apache have dictators or BDFL's that control a project. This isn't the case at all. Also, if Ben follows the practice of marking others RB's as applied, I would encourage Ben to also encourage those contributors who created their own RB tickets to close their own. This encourages meritocracy, and helps those person's build merit in the project, so that we can nominate them as PPMC members later on. My advice to Mesos as well -- adopt a practice where Committers and PPMC members (eventually PMC members) are the same (e.g., PMC == C). This reduces the barrier, and doesn't put people who are elected as committers who ultimately have merit and access to the code and can steward the project in a weird situation where they do NOT have the ability to have binding VOTEs on new committers and to have binding VOTEs on releases (a right reserved for PMC members only). > >I am not sure if ReviewBoard only gives these elevated permissions to >project lead(s) or if there is an option to also give them to committers >too. Also, is their recommended Apache way of doing this? See above :) HTH! Cheers, Chris > >Thanks, >Vinod > > >@vinodkone > > >On Sun, Feb 10, 2013 at 11:58 AM, Mattmann, Chris A (388J) < >[email protected]> wrote: > >> [Changing to mesos-dev@ since nothing private about this thread, and >>since >> public discussion is encouraged at Apache (and a good metric).] >> >> Hi Vinod, >> >> The folks to ask here would ASF infra, and the best bet would be to file >> an issue here: >> >> http://issues.apache.org/jira/browse/INFRA >> >> Requesting a Review Board account. >> >> Question: why would you ever need to mark someone else's Review Board as >> submitted? We operate here at Apache as individuals so not sure I get >>this. >> >> Cheers, >> Chris >> >> >> >> On 2/8/13 3:09 PM, "Vinod Kone" <[email protected]> wrote: >> >> >Just realized I need the same type of access for Apache Reviewboard >>too, >> >so >> >that I can mark other people's reviews as submitted. >> > >> >Thanks, >> >Vinod >> > >> > >> >@vinodkone >> > >> > >> >On Wed, Feb 6, 2013 at 2:38 PM, Vinod Kone <[email protected]> wrote: >> > >> >> Hi, >> >> >> >> I'm a new committer to the Apache Mesos project. >> >> >> >> I was wondering what is the process to get admin access to our >>project's >> >> >> >>builds(1< >> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Se >> >>t-JAVA_HOME/> >> >> >> >>,2< >> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disa >> >>ble-Java-Disable-Python-Disable-Webui/> >> >> >> >>,3< >> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set- >> >>JAVA_HOME/>) >> >> on Apache Jenkins server. >> >> >> >> NOTE: I already have login access (username: vinodkone) to Jenkins, >>but >> >> cannot see the "configure" link for our projects. >> >> >> >> Thanks, >> >> Vinod >> >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >>
