----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6665/#review16616 -----------------------------------------------------------
src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/6665/#comment35258> s/Resources/resources/ src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/6665/#comment35272> how about s/minimumResources/offerable/ ? src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/6665/#comment35260> free and minimum right? how about s/with free/with atleast minimum unused/ ? src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/6665/#comment35261> Why the line wrap? src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/6665/#comment35262> is it the review board or is the indentation bad here? src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/6665/#comment35264> Instead of making a copy (newAvailable), can't you just reuse available. You can just do available.clear() here and just insert into it? src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/6665/#comment35263> again, no need for line wrap src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/6665/#comment35265> no need for wrapping src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/6665/#comment35266> ditto - Vinod Kone On Feb. 11, 2013, 9:43 p.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6665/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2013, 9:43 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > Currently, every time we do an allocation we have to traverse the entire list > of active slaves an check each one to see if its whitelisted and if it has > resources to allocate. This patch keeps a set of all slaves that meet those > requirements, and updates it when slaves are added/removed and when resources > are allocated/recovered. > > > Diffs > ----- > > src/master/hierarchical_allocator_process.hpp 33e059c > > Diff: https://reviews.apache.org/r/6665/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Thomas Marshall > >
