----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7655/#review16898 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/7655/#comment35871> I think this comment could be more clear. src/slave/slave.cpp <https://reviews.apache.org/r/7655/#comment35870> Let's add a comment here: "the executor may be null because ...". Also, let's do the actual forwarding at the bottom of this function (put the comment there too). In the future when we change these semantics we'll still want to check if the executor exists (we could have gotten a bogus status update), but we'll only forward it if it's valid. src/slave/slave.cpp <https://reviews.apache.org/r/7655/#comment35866> Maybe LOG(FATAL) for now? src/slave/slave.cpp <https://reviews.apache.org/r/7655/#comment35867> Don't delete it, put it in completed! src/tests/status_update_manager_tests.cpp <https://reviews.apache.org/r/7655/#comment35869> Don't need this temporary. - Benjamin Hindman On Feb. 19, 2013, 8 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7655/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2013, 8 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Integrated SUM into slave. > > > This addresses bug MESOS-110. > https://issues.apache.org/jira/browse/MESOS-110 > > > Diffs > ----- > > include/mesos/mesos.proto 38235157d45bdccb676e5c3241c21b585a6f8801 > src/Makefile.am c94736df660a25b58dc47c07d9c56c3c26152a66 > src/slave/gc.cpp fe22f9b557215514e3d432d36af9dc0c377c437b > src/slave/paths.hpp fbf3fd84fb8f2590311b18d2afec2d2e0d30ef0a > src/slave/slave.hpp e9f7b659ca2860501840b3d01e69915ebd162039 > src/slave/slave.cpp d4721c3eb51db87278d05f6fbe2eadb8a3a9b4dd > src/slave/status_update_manager.hpp PRE-CREATION > src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed > src/tests/status_update_manager_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/7655/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
