-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9094/
-----------------------------------------------------------
(Updated Feb. 22, 2013, 12:32 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Benh review.
Rebased off trunk.
Description
-------
This is the meat of the resource monitoring design.
-Added a ResourceUsage protobuf.
-Added a ResourceMonitor process that periodically hits the isolation module
for usage information.
-Usage is exported to the Statistics process.
-Usage is available via a JSON endpoint.
Implementation of the isolation module code will follow in subsequent reviews.
This addresses bug MESOS-324.
https://issues.apache.org/jira/browse/MESOS-324
Diffs (updated)
-----
include/mesos/executor.hpp 0ea70528a74bb9ba7d2aaac85d2ff85928363869
include/mesos/mesos.proto 38235157d45bdccb676e5c3241c21b585a6f8801
src/Makefile.am c94736df660a25b58dc47c07d9c56c3c26152a66
src/files/files.cpp 84082ce6dab6c70bb21cd290119cbdd0169be29d
src/slave/cgroups_isolation_module.hpp
669efa14ba2603764aa68ae19a44e79dbfdec192
src/slave/cgroups_isolation_module.cpp
a2eba6f96f5d8a4b1257571aa29e37c5682aab8d
src/slave/flags.hpp 39e57f4104ee7a1538436ebbb9493581e28c99dd
src/slave/isolation_module.hpp b962365ebeddd047896a66b02a327aa26ae323d3
src/slave/lxc_isolation_module.hpp 2bc844f491befbe588965da2ada7cfcef0b6f0a4
src/slave/lxc_isolation_module.cpp 30cff2a49339bb07030727d30352536a0a22d58c
src/slave/monitor.hpp PRE-CREATION
src/slave/monitor.cpp PRE-CREATION
src/slave/process_based_isolation_module.hpp
f1817192582e3646f8dcf17934ba7998829e8fd6
src/slave/process_based_isolation_module.cpp
12a579cba56cd3dac384bc7919b0d5537b0e429d
src/slave/slave.hpp e9f7b659ca2860501840b3d01e69915ebd162039
src/slave/slave.cpp d4721c3eb51db87278d05f6fbe2eadb8a3a9b4dd
src/tests/utils.hpp be457117515ee727af101370b26bf9188afb8f45
third_party/libprocess/include/process/statistics.hpp
faefad2e374e08e4e0f88750c4c4eee74bce62d7
third_party/libprocess/src/statistics.cpp
29d08f05c6ab7b69d587a44aab860b4dfe645b89
third_party/libprocess/src/tests/statistics_tests.cpp
0aaab3526618171c7cfbd11d40d614344bcbfd0a
Diff: https://reviews.apache.org/r/9094/diff/
Testing
-------
make check
Although I didn't add tests, I've manually tested end-to-end with my future
reviews.
Thanks,
Ben Mahler