----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8535/#review16901 -----------------------------------------------------------
Ship it! src/slave/flags.hpp <https://reviews.apache.org/r/8535/#comment35876> s/re-connect/reconnect/ src/slave/slave.cpp <https://reviews.apache.org/r/8535/#comment35873> I'd prefer you did frameworkInfo.checkpoint() everywhere because it's more clear that checkpoint "blocks" are framework specific and not slave specific. src/slave/slave.cpp <https://reviews.apache.org/r/8535/#comment35872> Move this comment. src/slave/state.cpp <https://reviews.apache.org/r/8535/#comment35874> Single quotes here and elsewhere? src/tests/slave_state_tests.cpp <https://reviews.apache.org/r/8535/#comment35875> Did you remove this from paths.hpp too? - Benjamin Hindman On Feb. 19, 2013, 8:02 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8535/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2013, 8:02 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Checkpoints slave id, framework pid, executor pids (libprocess, execed, > forked) and task info. > > > Diffs > ----- > > src/exec/exec.cpp 821a94fab1f5969183ecf9e28d7b6bc10920db24 > src/slave/cgroups_isolation_module.hpp > 669efa14ba2603764aa68ae19a44e79dbfdec192 > src/slave/cgroups_isolation_module.cpp > 14f549edaf1b37a6bca8f75309864333ae775e7c > src/slave/flags.hpp 39e57f4104ee7a1538436ebbb9493581e28c99dd > src/slave/isolation_module.hpp b962365ebeddd047896a66b02a327aa26ae323d3 > src/slave/lxc_isolation_module.hpp 2bc844f491befbe588965da2ada7cfcef0b6f0a4 > src/slave/lxc_isolation_module.cpp 30cff2a49339bb07030727d30352536a0a22d58c > src/slave/paths.hpp fbf3fd84fb8f2590311b18d2afec2d2e0d30ef0a > src/slave/process_based_isolation_module.hpp > f1817192582e3646f8dcf17934ba7998829e8fd6 > src/slave/process_based_isolation_module.cpp > 12a579cba56cd3dac384bc7919b0d5537b0e429d > src/slave/slave.hpp e9f7b659ca2860501840b3d01e69915ebd162039 > src/slave/slave.cpp d4721c3eb51db87278d05f6fbe2eadb8a3a9b4dd > src/slave/state.hpp c1e4c782380b0076313d2216c40e86774050d445 > src/slave/state.cpp 2688567719c5b12f1d8a56fa6193c11d4077685b > src/tests/protobuf_io_tests.cpp 5c9bf4664d413a34859608dd727deacf3ce4b402 > src/tests/slave_state_tests.cpp 1136ea93cffb1483458edad2605b0b4f83b61c44 > src/tests/status_update_manager_tests.cpp PRE-CREATION > src/tests/utils.hpp be457117515ee727af101370b26bf9188afb8f45 > > Diff: https://reviews.apache.org/r/8535/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
