----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8680/#review16907 -----------------------------------------------------------
Ship it! src/slave/paths.hpp <https://reviews.apache.org/r/8680/#comment35877> These helper functions SHOULD NOT be using CHECK or CHECK_SOME but returning a Try/Result instead. src/slave/slave.cpp <https://reviews.apache.org/r/8680/#comment35878> Why are you doing this? src/slave/state.cpp <https://reviews.apache.org/r/8680/#comment35888> :( src/slave/state.cpp <https://reviews.apache.org/r/8680/#comment35882> Another good spot to return error (for here and all the other globs). - Benjamin Hindman On Feb. 19, 2013, 8:05 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8680/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2013, 8:05 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > This only covers recovering slave state. > > Recovering status update manager and isolation modules will be coming in next > reviews. > > > Diffs > ----- > > src/Makefile.am c94736df660a25b58dc47c07d9c56c3c26152a66 > src/common/type_utils.hpp fde69aeec403b3455839dca6b0b2e1507d81ba00 > src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c > src/slave/flags.hpp 39e57f4104ee7a1538436ebbb9493581e28c99dd > src/slave/http.cpp b94197013ac0d5dd95d6dabb44812905a123184a > src/slave/isolation_module.hpp b962365ebeddd047896a66b02a327aa26ae323d3 > src/slave/lxc_isolation_module.hpp 2bc844f491befbe588965da2ada7cfcef0b6f0a4 > src/slave/paths.hpp fbf3fd84fb8f2590311b18d2afec2d2e0d30ef0a > src/slave/process_based_isolation_module.hpp > f1817192582e3646f8dcf17934ba7998829e8fd6 > src/slave/process_based_isolation_module.cpp > 12a579cba56cd3dac384bc7919b0d5537b0e429d > src/slave/slave.hpp e9f7b659ca2860501840b3d01e69915ebd162039 > src/slave/slave.cpp d4721c3eb51db87278d05f6fbe2eadb8a3a9b4dd > src/slave/state.hpp c1e4c782380b0076313d2216c40e86774050d445 > src/slave/state.cpp 2688567719c5b12f1d8a56fa6193c11d4077685b > src/slave/status_update_manager.hpp PRE-CREATION > src/tests/exception_tests.cpp 13355d08788432ed07679daf24c2d74cc12a7f11 > src/tests/fault_tolerance_tests.cpp > 44eef03aedd89ddfce8491add73918d8f453a0f2 > src/tests/paths_tests.cpp PRE-CREATION > src/tests/reaper_tests.cpp PRE-CREATION > src/tests/slave_recovery_tests.cpp PRE-CREATION > src/tests/slave_state_tests.cpp 1136ea93cffb1483458edad2605b0b4f83b61c44 > src/tests/status_update_manager_tests.cpp PRE-CREATION > src/tests/utils.hpp be457117515ee727af101370b26bf9188afb8f45 > > Diff: https://reviews.apache.org/r/8680/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
