----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8736/#review16916 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/8736/#comment35890> s/unr/Unr/ src/slave/slave.cpp <https://reviews.apache.org/r/8736/#comment35894> If you make 'recovered' a Future instead then you can wait for that event in the first doReliableRegistration and not need these complicated semantics. src/slave/slave.cpp <https://reviews.apache.org/r/8736/#comment35891> s/re-/re/ src/slave/status_update_manager.cpp <https://reviews.apache.org/r/8736/#comment35895> s/Re-t/ret/ src/slave/status_update_manager.cpp <https://reviews.apache.org/r/8736/#comment35896> But ... unacknowledged is a word! - Benjamin Hindman On Feb. 19, 2013, 8:06 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8736/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2013, 8:06 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Status update manager now recovers the update stream and re-sends any pending > updates. > > > Diffs > ----- > > src/master/master.cpp 814a6e1af2c7caf77452748dfc9e6935d8386d8f > src/slave/flags.hpp 39e57f4104ee7a1538436ebbb9493581e28c99dd > src/slave/slave.hpp e9f7b659ca2860501840b3d01e69915ebd162039 > src/slave/slave.cpp d4721c3eb51db87278d05f6fbe2eadb8a3a9b4dd > src/slave/status_update_manager.hpp PRE-CREATION > src/slave/status_update_manager.cpp PRE-CREATION > src/tests/slave_recovery_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/8736/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
