----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9552/#review16952 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/9552/#comment35928> s/, used for/that can be used by/ ? include/mesos/mesos.proto <https://reviews.apache.org/r/9552/#comment35927> s/be/to be/ include/mesos/mesos.proto <https://reviews.apache.org/r/9552/#comment35930> Why is it important for it to not contain spaces? Isn't it upto the framework? If definitely required, how about validating this (spaces do not exist) in the code on the master/slave? src/examples/java/TestFramework.java <https://reviews.apache.org/r/9552/#comment35929> Can you update the Hadoop framework too? I think you also missed balloon and cpuset frameworks? - Vinod Kone On Feb. 22, 2013, 12:31 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9552/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2013, 12:31 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See comment above the source field for the motivation. > > > Diffs > ----- > > include/mesos/mesos.proto 38235157d45bdccb676e5c3241c21b585a6f8801 > src/examples/java/TestFramework.java > 8417394487a80b439e7d9897c83f0b2c1eb17ff4 > src/examples/long_lived_framework.cpp > 04ac678387dd78104b5d42fa1f7b5de1849b0701 > src/examples/python/test_framework.py > 269f532733ab82378bc1bd643107e6f9f2945d8b > src/examples/test_framework.cpp b9ab692414e4df64f176fc1ecd05f24ff089bde0 > src/master/http.cpp 790961d6890841c456485491516d1991fe35ec16 > src/slave/http.cpp b94197013ac0d5dd95d6dabb44812905a123184a > src/slave/slave.hpp e9f7b659ca2860501840b3d01e69915ebd162039 > src/webui/master/static/slave_executor.html > bd06e69b3c99a0a44993c31429d877914b644a1d > src/webui/master/static/slave_framework.html > c66150ecb794300239c92ceaf684bfd3f1cb007e > > Diff: https://reviews.apache.org/r/9552/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
