-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9630/#review17160
-----------------------------------------------------------

Ship it!


Fantastic!


third_party/Makefile.am
<https://reviews.apache.org/r/9630/#comment36339>

    What are we patching..?



third_party/libprocess/third_party/Makefile.am
<https://reviews.apache.org/r/9630/#comment36341>

    Can we decide on a consistent style?
    
    Some spots we align with the first entry after '=', other spots (introduced 
in this change), we include the first entry on the next line and indent by 2.


- Ben Mahler


On Feb. 26, 2013, 8:21 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9630/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2013, 8:21 p.m.)
> 
> 
> Review request for mesos, Vinod Kone and Ben Mahler.
> 
> 
> Description
> -------
> 
> This should improve build speeds, reduce distribution size, and generally 
> simplify maintainability (especially as it relates to upgrades).
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 8c74525ff6381b6d8624622a758b792fd631cd8c 
>   src/python/setup.py.in f24b8f7878b3dabf6d05515ed7645126ecf1f30d 
>   third_party/Makefile.am fb8984e8d1bbc527683eec37a1a65cb85fb28fc1 
>   third_party/boost-1.53.0.tar.gz 770d837aaba23d031b04ad77658f339587174aae 
>   third_party/glog-0.3.1.tar.gz 9812869cfcc7855fc31a855c2ef6f790d8e3deae 
>   third_party/gmock-1.6.0.tar.gz 811c6bea888520127003b45e83a2d74ea626165a 
>   third_party/libprocess/third_party/Makefile.am 
> 150b0d8ad16c5ea3de3a96290d0859bc1a192a15 
>   third_party/versions.am 3daf2d0985917d8164e7a17e4041ac581a5069eb 
> 
> Diff: https://reviews.apache.org/r/9630/diff/
> 
> 
> Testing
> -------
> 
> make distcheck
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Reply via email to