[
https://issues.apache.org/jira/browse/MESOS-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13588890#comment-13588890
]
Benjamin Hindman commented on MESOS-335:
----------------------------------------
I missed this here https://reviews.apache.org/r/6755. :( We should definitely
not be multiplying to nanoseconds in Duration. I think Vinod might have been
inspired by what John Sirois had done in Twitter commons, but they probably
didn't use a double there.
Given all the options (or lack there of) IMHO using a double with a base unit
of seconds is actually very powerful given that most C/C++ APIs expect seconds
this gives libev a lot more fine-grained information with the added bonus of
getting "easy" conversion when calling functions that expect seconds without
the need for multiplication or division.
> Statistics.truncate is flaky.
> -----------------------------
>
> Key: MESOS-335
> URL: https://issues.apache.org/jira/browse/MESOS-335
> Project: Mesos
> Issue Type: Bug
> Reporter: Benjamin Mahler
> Assignee: Benjamin Mahler
>
> Looks like a double comparison issue..?
> [ RUN ] Statistics.truncate
> ../../../third_party/libprocess/src/tests/statistics_tests.cpp:58: Failure
> Expected: (Clock::now()) >= (values.get().begin()->first.secs()), actual:
> 1.36184e+09 vs 1.36184e+09
> ../../../third_party/libprocess/src/tests/statistics_tests.cpp:71: Failure
> Expected: (Clock::now()) >= (values.get().begin()->first.secs()), actual:
> 1.36193e+09 vs 1.36193e+09
> [ FAILED ] Statistics.truncate (1 ms)
> Another flaky one:
> [ RUN ] Statistics.archive
> ../../../third_party/libprocess/src/tests/statistics_tests.cpp:175: Failure
> Value of: values.get().empty()
> Actual: false
> Expected: true
> [ FAILED ] Statistics.archive (2 ms)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
