----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8837/#review17253 -----------------------------------------------------------
Ship it! src/slave/status_update_manager.cpp <https://reviews.apache.org/r/8837/#comment36684> Ok. Just keep in mind that you may need to debug things and you'll lose information by doing this as well. Could archive? But then we need to think about gc.. - Ben Mahler On Feb. 19, 2013, 8:09 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8837/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2013, 8:09 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Currently we only gc task meta directories. > > TODO: gc'ing executor directories. this is tricky because of the async nature > status updates manager. > > > Diffs > ----- > > src/slave/slave.cpp d4721c3eb51db87278d05f6fbe2eadb8a3a9b4dd > src/slave/status_update_manager.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/8837/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
