> On March 5, 2013, 8:48 a.m., Benjamin Hindman wrote:
> > third_party/libprocess/src/statistics.cpp, lines 358-359
> > <https://reviews.apache.org/r/9748/diff/1/?file=265729#file265729line358>
> >
> >     Any reason not to 'else if'?

Fixed, thanks for checking me on that.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9748/#review17389
-----------------------------------------------------------


On March 5, 2013, 8:50 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9748/
> -----------------------------------------------------------
> 
> (Updated March 5, 2013, 8:50 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> I left a CHECK in the snapshot endpoint after having changed the semantics 
> around empty time series.
> Now that we have time series archival, empty time series are possible.
> 
> 
> This addresses bug MESOS-374.
>     https://issues.apache.org/jira/browse/MESOS-374
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/src/statistics.cpp 
> db092d95a526ea59210f6f637f4fc13d3aafd9bd 
> 
> Diff: https://reviews.apache.org/r/9748/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to