> On March 5, 2013, 10:42 p.m., Vinod Kone wrote: > > src/Makefile.am, line 135 > > <https://reviews.apache.org/r/9761/diff/1/?file=266529#file266529line135> > > > > so the "@" suppresses warnings?
The @ means: don't echo this command on the output. > On March 5, 2013, 10:42 p.m., Vinod Kone wrote: > > src/Makefile.am, line 540 > > <https://reviews.apache.org/r/9761/diff/1/?file=266529#file266529line540> > > > > I thought the style we decided was to not use "-" when doing "rm -f"? The rest of this file uses "-" on it's rm's so I figured I'd just conform rather than change all the rm's in this file. I'd rather punt, if you really want it though I'll do it :) - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9761/#review17428 ----------------------------------------------------------- On March 5, 2013, 10:35 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9761/ > ----------------------------------------------------------- > > (Updated March 5, 2013, 10:35 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This seems unnecessary and was hiding some issues I was investigating. > > > Diffs > ----- > > src/Makefile.am 851237cbf8db071d27de40c01d702514713b861a > > Diff: https://reviews.apache.org/r/9761/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
