> On March 5, 2013, 11:25 p.m., Benjamin Hindman wrote: > > hadoop/TUTORIAL.sh, line 267 > > <https://reviews.apache.org/r/9174/diff/10/?file=266585#file266585line267> > > > > What about aligning these? I don't know whether or not it's worth > > obeying style guidelines here for readability, up to you.
I've been aligning line breaks as +2 in this tutorial. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9174/#review17432 ----------------------------------------------------------- On March 5, 2013, 10:39 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9174/ > ----------------------------------------------------------- > > (Updated March 5, 2013, 10:39 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See Summary. > > Also, we only run 'ant' once instead of twice. > > > This addresses bug MESOS-352. > https://issues.apache.org/jira/browse/MESOS-352 > > > Diffs > ----- > > hadoop/Makefile.am d1aa75535ab617f9e4a0b8a0db84d77f1916acc4 > hadoop/TUTORIAL.sh 5670d6afa96f858d437f26885e862712bbf72b71 > hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch PRE-CREATION > hadoop/hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch PRE-CREATION > > Diff: https://reviews.apache.org/r/9174/diff/ > > > Testing > ------- > > make hadoop-2.0.0-mr1-cdh4.1.2 > make hadoop-0.20.2-cdh3u3 > make hadoop-0.20.205.0 > > > Thanks, > > Vinod Kone > >
