> On March 7, 2013, 6:08 p.m., Vinod Kone wrote: > > third_party/libprocess/third_party/stout/include/stout/os.hpp, line 870 > > <https://reviews.apache.org/r/9793/diff/1/?file=267807#file267807line870> > > > > <= 0 ?
The contract of sysctl is such that on error it returns -1 and sets errno, so if it returns 0, errno will not be set (and hence we'll provide a non-deterministic error message!) - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9793/#review17553 ----------------------------------------------------------- On March 7, 2013, 3:15 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9793/ > ----------------------------------------------------------- > > (Updated March 7, 2013, 3:15 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See description. > > > Diffs > ----- > > third_party/libprocess/third_party/stout/include/stout/os.hpp > da14a8fb95b69684c899e04ca79a1ad8eb11b2b8 > > Diff: https://reviews.apache.org/r/9793/diff/ > > > Testing > ------- > > Tested manually, I will be splitting apart the monolithic stout tests in > another review chain. > > > Thanks, > > Ben Mahler > >
