----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9806/#review17578 -----------------------------------------------------------
src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/9806/#comment37272> After David did all that work? ;) src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/9806/#comment37344> Why can these be killed? I'd give a ship it but this seems concerning. - Benjamin Hindman On March 8, 2013, 2:40 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9806/ > ----------------------------------------------------------- > > (Updated March 8, 2013, 2:40 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/cgroups.cpp edce52475eb58f2aa8f1c99bcaf3cb269167fc1e > src/slave/cgroups_isolation_module.cpp > c7ca32c8122ce97f77a5ba68f6ad3dc1f17704f7 > src/tests/cgroups_tests.cpp ed419eb174a095786fb6de9e181d42587e5b40e2 > src/tests/utils.hpp 0d4edad4787f92f86b1486b6b510f46a62d7d541 > > Diff: https://reviews.apache.org/r/9806/diff/ > > > Testing > ------- > > ./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose > > > Thanks, > > Vinod Kone > >
